[Mlir-commits] [mlir] [MLIR][Linalg] Add static shape masking option in vectorization (PR #214812)

Federico Bruzzone llvmlistbot at llvm.org
Wed Aug 12 08:01:32 PDT 2026


================

----------------
FedericoBruzzone wrote:

> Sure, once the solution is accepted, it will be cleaned up

What is usually suggested to do, genuinely speaking, is to make the PR easier to review by making it as _clean_ as possible. From the _contributing_ page, under [How to Submit a Patch](https://llvm.org/docs/Contributing.html#how-to-submit-a-patch), a patch should: "_not contain any unrelated changes_".

> Could you please clarify the two separate things?
> The masking infrastructure is already there, the only addition is a new way to engage it (with a new vectorize option).

According to your PR body, there are two paragraphs that start with: _This PR adds..._. 
I thought, at this point mistakenly, that they were two separate additions and that they were separable in some way :'D


https://github.com/llvm/llvm-project/pull/214812


More information about the Mlir-commits mailing list