[Mlir-commits] [mlir] [mlir][gpu][NFC] Remove unused patterns in GpuModuleToBinaryPass (PR #215736)

Jamie Phan llvmlistbot at llvm.org
Tue Aug 11 23:29:18 PDT 2026


https://github.com/ordinary-jamie created https://github.com/llvm/llvm-project/pull/215736

The initial implementation of this pass used patterns but during PR review was removed, but the pattern set was accidently left in during diff 3->4; see https://reviews.llvm.org/D154149?id=547745

>From c9d2da50de0288364791e080be1a85cb6d8ade89 Mon Sep 17 00:00:00 2001
From: ordinary-jamie <101677823+ordinary-jamie at users.noreply.github.com>
Date: Wed, 12 Aug 2026 16:24:32 +1000
Subject: [PATCH] [mlir][gpu][NFC] Remove unused patterns in
 GpuModuleToBinaryPass

The initial implementation of this pass used patterns but during PR
review was removed, but the pattern set was accidently left in during
diff 3->4; see https://reviews.llvm.org/D154149?id=547745
---
 mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp b/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
index 93e07bef5af79..01f4cc12d25c1 100644
--- a/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
+++ b/mlir/lib/Dialect/GPU/Transforms/ModuleToBinary.cpp
@@ -36,7 +36,6 @@ class GpuModuleToBinaryPass
 } // namespace
 
 void GpuModuleToBinaryPass::runOnOperation() {
-  RewritePatternSet patterns(&getContext());
   auto targetFormat =
       llvm::StringSwitch<std::optional<CompilationTarget>>(compilationTarget)
           .Cases({"offloading", "llvm"}, CompilationTarget::Offload)



More information about the Mlir-commits mailing list