[Mlir-commits] [mlir] [mlir][arith] Fold ceildivsi with MININT operands (PR #214637)

[Hung Kuan Tseng]

Tim096 wrote:

Took the same idea one step further while I was there: the remainder check is now
`quotient * b == a` rather than `a.srem(b).isZero()`, which is the multiply
`ExpandOps.cpp` already uses for this expansion, so the same-sign path avoids a
second division too. Checked exhaustively against the remainder form over every
i8 pair. #215696 gets the same two changes for `index::calculateCeilDivS`.

One thing worth flagging, since it is not obvious from the history: my two merged
commits are authored as `曾鈜寬 Tseng Hung Kuan <P76091014 at gs.ncku.edu.tw>` and
this branch uses `Hung-Kuan Tseng <tseng.tim096 at gmail.com>`. Same person -- I have
settled on the latter from here on.

Thanks for the reviews. I don't have commit access, so could you merge this for me
once premerge is green? `Hung-Kuan Tseng <tseng.tim096 at gmail.com>`


https://github.com/llvm/llvm-project/pull/214637