[Mlir-commits] [mlir] [mlir][linalg] Support subtracting accumulation in partial reduction … (PR #214033)

[llvmlistbot at llvm.org]

pstarkcdpr wrote:

@banach-space This is all brand new to me. The whole overflow flag conversation came simply from the question of whether to propagate the overflow flags. I haven't seen them in the wild at all, and they certainly aren't in my repro case, so the example above is purely theoretical. If you think that `nsw` is safe because it carries a strong guarantee, then I'm happy to propagate the flags instead of bailing. You're in a much better position to make that call than me. I think that `nuw` case is still bad, right? Because `0 - x` will wrap for any unsigned value of `x`?

https://github.com/llvm/llvm-project/pull/214033