[Mlir-commits] [mlir] [mlir] [arith] Fold trunc(extremum(ext(lhs), ext(rhs))) (PR #214658)

[Mehdi Amini]

joker-eph wrote:

 
> If we don't want this to be a canonicalization, how do you think about to make this a populate*Patterns API? Or make this a pass?

I'm very wary of the proliferation of `populate*Patterns` APIs: most of these should just not exist if they can't be include in a pass with a very clear semantics (and without creating something like "one pass per pattern" of course, think "LLVM pass granularity").

https://github.com/llvm/llvm-project/pull/214658