[Mlir-commits] [mlir] [mlir][gpu] Don't request C wrappers for private device functions (PR #214552)

[Fabian Mora]

fabianmcg wrote:

> Thanks! Yes, our pipeline runs DCE and it (correctly) eliminates nothing because before inlining all of these functions are reachable from a kernel. Dead code materializes after inlining and at that point the ciface wrappers keep the unused functions alive.

Symbol DCE should be applied after inlining, also, the pass is fix-point so if the interface definitions are being emitted with private visibility, then it should remove them. To me this points to a possible a deeper bug, as we should likely never create emit c interface for private functions (or error when this is requested). I mean, what's the point if the whole point of the c interface is for visible functions so users can call them.

https://github.com/llvm/llvm-project/pull/214552