[Mlir-commits] [mlir] [mlir][tosa] Add more informative error messages to block scaled types (PR #211569)

[Sayan Saha]

================
@@ -172,7 +172,19 @@ def AtLeastRankOne : And<[
   CPred<"::llvm::cast<::mlir::RankedTensorType>($_self).getRank() >= 1">]>;
 
 def IsValidBlockScaledTensorType
-    : CPred<"::mlir::succeeded(::mlir::tosa::verifyBlockScaledTensorType($_self, false))">;
+    : CPred<"::mlir::succeeded(::mlir::tosa::"
+            "verifyBlockScaledTensorType($_self))">;
+
+// Analogous to ShapedContainerType, but with additional 'summary' information.
----------------
sahas3 wrote:

Does this need to be tightly in sync with `ShapedContainerType` -- I don't think so? Otherwise, adding an optional `summary` field (default is empty string) in `ShapedContainerType` will be better for long term.

https://github.com/llvm/llvm-project/pull/211569