[Mlir-commits] [mlir] 0343527 - [mlir][tosa] Fold reshape of dense resource constants (#213225)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Tue Aug 4 04:55:59 PDT 2026
Author: Thibaut Goetghebuer-Planchon
Date: 2026-08-04T12:55:55+01:00
New Revision: 03435270d2662be52b360c929d19a2f666eb1af5
URL: https://github.com/llvm/llvm-project/commit/03435270d2662be52b360c929d19a2f666eb1af5
DIFF: https://github.com/llvm/llvm-project/commit/03435270d2662be52b360c929d19a2f666eb1af5.diff
LOG: [mlir][tosa] Fold reshape of dense resource constants (#213225)
Add support for `DenseResourceElementsAttr` in TOSA reshape folding.
Added:
Modified:
mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
mlir/test/Dialect/Tosa/constant_folding.mlir
Removed:
################################################################################
diff --git a/mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp b/mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
index bb3c0f16b97aa..d4ae8e920f489 100644
--- a/mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
+++ b/mlir/lib/Dialect/Tosa/IR/TosaCanonicalizations.cpp
@@ -2117,13 +2117,18 @@ OpFoldResult ReshapeOp::fold(FoldAdaptor adaptor) {
if (!inputTy.getElementType().isIntOrIndexOrFloat())
return {};
+ // Constants must have static shape.
+ if (!outputTy.hasStaticShape())
+ return {};
+
+ // Reshaping a resource-backed constant only requires updating its type.
+ if (auto operand = llvm::dyn_cast_if_present<DenseResourceElementsAttr>(
+ adaptor.getInput1()))
+ return DenseResourceElementsAttr::get(outputTy, operand.getRawHandle());
+
// reshape(const(x)) -> const(reshape-attr(x))
if (auto operand =
llvm::dyn_cast_if_present<DenseElementsAttr>(adaptor.getInput1())) {
- // Constants must have static shape.
- if (!outputTy.hasStaticShape())
- return {};
-
// Okay to duplicate splat constants.
if (operand.isSplat())
return SplatElementsAttr::get(outputTy,
diff --git a/mlir/test/Dialect/Tosa/constant_folding.mlir b/mlir/test/Dialect/Tosa/constant_folding.mlir
index 118746704d4c4..a2a0cab592220 100644
--- a/mlir/test/Dialect/Tosa/constant_folding.mlir
+++ b/mlir/test/Dialect/Tosa/constant_folding.mlir
@@ -889,6 +889,25 @@ func.func @reshape_splat() -> tensor<6x5x4xi32> {
// -----
+// CHECK-LABEL: @reshape_dense_resource
+func.func @reshape_dense_resource() -> tensor<4xf32> {
+ // CHECK: %[[RESHAPED:.+]] = "tosa.const"() <{values = dense_resource<reshape_resource> : tensor<4xf32>}> : () -> tensor<4xf32>
+ %input = "tosa.const"() <{values = dense_resource<reshape_resource> : tensor<2x2xf32>}> : () -> tensor<2x2xf32>
+ %shape = tosa.const_shape {values = dense<4> : tensor<1xindex>} : () -> !tosa.shape<1>
+ %reshape = tosa.reshape %input, %shape : (tensor<2x2xf32>, !tosa.shape<1>) -> tensor<4xf32>
+ // CHECK: return %[[RESHAPED]]
+ return %reshape : tensor<4xf32>
+}
+{-#
+ dialect_resources: {
+ builtin: {
+ reshape_resource: "0x040000003f800000400000004040000040800000"
+ }
+ }
+#-}
+
+// -----
+
// CHECK-LABEL: @slice_splat
func.func @slice_splat() -> tensor<1x1x1xi32> {
// CHECK: %[[SLICE:.+]] = "tosa.const"() <{values = dense<42> : tensor<1x1x1xi32>}
More information about the Mlir-commits
mailing list