[Mlir-commits] [mlir] [mlir][ArmNeon] Add linalg.matmul e2e tests (PR #212809)

[Andrzej Warzyński]

banach-space wrote:

> I was trying to keep matmul.mlir aligned with other folders, but good point, done :D

We should rename the other tests as well then - names should be descriptive and consistent.

Btw, and apologies for not flagging this earlier, but I think that you got inspired by mlir/test/Integration/Dialect/Vector/CPU/ArmNeon/vector-contract-i8mm.mlir a bit too much :) Basically, we should be able to target I8MM for any linalg.matmul to operates on `i8` and accumulates to `i32`. To make that possible, we use `linalg.pack` -> `linalg.mmt4d` -> `linalg.unpack`. Basically, the I8MM test should match mlir/test/Integration/Dialect/Linalg/CPU/ArmSVE/pack-unpack-mmt4d.mlir rather than vector-contract-i8mm.mlir . Does it make sense?

Again, apologies for the confusion.

https://github.com/llvm/llvm-project/pull/212809