https://github.com/banach-space commented: Many thanks! The naming of the tests feels off. Why not `matmul-i8.mlir` and `matmul-f32.mlir`? I've left some additional comments inline. https://github.com/llvm/llvm-project/pull/212809