[Mlir-commits] [mlir] [mlir][Vector] Reject invalid inline yields (PR #206218)

[Andrzej Warzyński]

================
@@ -794,3 +794,18 @@ llvm.func @caller_cf_br_terminator(%arg0 : i64) -> i64 {
   %0 = llvm.call @callee_cf_br_terminator(%arg0) : (i64) -> i64
   llvm.return %0 : i64
 }
+
+// -----
+// Skip callees with non-LLVM function exits.
+
+llvm.func @callee_vector_yield_terminator(%arg0 : vector<8xf32>) {
+  %0 = math.atanh %arg0 : vector<8xf32>
+  vector.yield %0 : vector<8xf32>
+}
+
----------------
banach-space wrote:

+1

>From https://mlir.llvm.org/docs/Dialects/Vector/#vectoryield-vectoryieldop
> https://mlir.llvm.org/docs/Dialects/Vector/#vectoryield-vectoryieldop

An LLVM function is not a Vector dialect Op region, so this usage is invalid and should be rejected by the Op verifier.

https://github.com/llvm/llvm-project/pull/206218