[Mlir-commits] [mlir] [mlir][affine] Add store sinking transformation for AffineIfOp (PR #213531)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/mlir/lib/Dialect/Affine/Transforms/CMakeFiles/obj.MLIRAffineTransforms.dir/AffineScalarReplacement.cpp.obj</summary>

```
FAILED: [code=1] tools/mlir/lib/Dialect/Affine/Transforms/CMakeFiles/obj.MLIRAffineTransforms.dir/AffineScalarReplacement.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\mlir\lib\Dialect\Affine\Transforms -IC:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Affine\Transforms -IC:\_work\llvm-project\llvm-project\build\tools\mlir\include -IC:\_work\llvm-project\llvm-project\mlir\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\mlir\lib\Dialect\Affine\Transforms\CMakeFiles\obj.MLIRAffineTransforms.dir\AffineScalarReplacement.cpp.obj /Fdtools\mlir\lib\Dialect\Affine\Transforms\CMakeFiles\obj.MLIRAffineTransforms.dir\ -c -- C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Affine\Transforms\AffineScalarReplacement.cpp
In file included from C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Affine\Transforms\AffineScalarReplacement.cpp:14:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/Analysis/AliasAnalysis.h:17:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/Operation.h:16:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/Block.h:16:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/BlockSupport.h:16:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/Value.h:16:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/Types.h:12:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/TypeSupport.h:16:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/IR/MLIRContext.h:13:
In file included from C:\_work\llvm-project\llvm-project\mlir\include\mlir/Support/TypeID.h:21:
In file included from C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/Allocator.h:20:
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/SmallVector.h(1202,7): error: static assertion failed due to requirement 'sizeof((anonymous namespace)::IfSinkPlan) <= 256': You are trying to use a default number of inlined elements for `SmallVector<T>` but `sizeof(T)` is really big! Please use an explicit number of inlined elements with `SmallVector<T, N>` to make sure you really want that much inline storage.
1202 |       sizeof(T) <= 256,
|       ^~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/SmallVector.h(1234,24): note: in instantiation of template class 'llvm::CalculateSmallVectorDefaultInlinedElements<(anonymous namespace)::IfSinkPlan>' requested here
1234 |           unsigned N = CalculateSmallVectorDefaultInlinedElements<T>::value>
|                        ^
C:\_work\llvm-project\llvm-project\mlir\lib\Dialect\Affine\Transforms\AffineScalarReplacement.cpp(266,3): note: in instantiation of default argument for 'SmallVector<IfSinkPlan>' required here
266 |   SmallVector<IfSinkPlan> plans;
|   ^~~~~~~~~~~~~~~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/ADT/SmallVector.h(1202,17): note: expression evaluates to '328 <= 256'
1202 |       sizeof(T) <= 256,
|       ~~~~~~~~~~^~~~~~
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/213531