[Mlir-commits] [mlir] 5d48370 - [mlir][memref] Pass TypeConverter to ConvertMemrefStore (#194356)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Apr 28 07:44:35 PDT 2026


Author: Daniel Hernandez-Juarez
Date: 2026-04-28T16:44:30+02:00
New Revision: 5d48370b260f3f12c9fe5402dfcb68d634f696c1

URL: https://github.com/llvm/llvm-project/commit/5d48370b260f3f12c9fe5402dfcb68d634f696c1
DIFF: https://github.com/llvm/llvm-project/commit/5d48370b260f3f12c9fe5402dfcb68d634f696c1.diff

LOG: [mlir][memref] Pass TypeConverter to ConvertMemrefStore (#194356)

Commit 20b925a28a29 dropped the TypeConverter from ConvertMemrefStore
when adding the disableAtomicRMW flag. Restore it.

Added: 
    

Modified: 
    mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp b/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
index d24224355ed51..8686f22c9e3c2 100644
--- a/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
+++ b/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
@@ -415,8 +415,9 @@ struct ConvertMemRefReinterpretCast final
 struct ConvertMemrefStore final : OpConversionPattern<memref::StoreOp> {
   using OpConversionPattern::OpConversionPattern;
 
-  ConvertMemrefStore(MLIRContext *context, bool disableAtomicRMW)
-      : OpConversionPattern<memref::StoreOp>(context),
+  ConvertMemrefStore(const TypeConverter &typeConverter, MLIRContext *context,
+                     bool disableAtomicRMW)
+      : OpConversionPattern<memref::StoreOp>(typeConverter, context),
         disableAtomicRMW(disableAtomicRMW) {}
 
   LogicalResult
@@ -639,7 +640,8 @@ void memref::populateMemRefNarrowTypeEmulationPatterns(
                ConvertMemRefAssumeAlignment, ConvertMemRefMemorySpaceCast,
                ConvertMemRefSubview, ConvertMemRefReinterpretCast>(
       typeConverter, patterns.getContext());
-  patterns.insert<ConvertMemrefStore>(patterns.getContext(), disableAtomicRMW);
+  patterns.insert<ConvertMemrefStore>(typeConverter, patterns.getContext(),
+                                      disableAtomicRMW);
   memref::populateResolveExtractStridedMetadataPatterns(patterns);
 }
 


        


More information about the Mlir-commits mailing list