[Mlir-commits] [mlir] [mlir][memref] Pass TypeConverter to ConvertMemrefStore (PR #194356)

Daniel Hernandez-Juarez llvmlistbot at llvm.org
Mon Apr 27 23:32:36 PDT 2026


https://github.com/dhernandez0 updated https://github.com/llvm/llvm-project/pull/194356

>From a5af1f476dffb79ff6b0777fb935c46269dd6bd2 Mon Sep 17 00:00:00 2001
From: Daniel Hernandez <danherna at amd.com>
Date: Mon, 27 Apr 2026 14:19:35 +0200
Subject: [PATCH] [mlir][memref] Pass TypeConverter to ConvertMemrefStore

Commit 20b925a28a29 dropped the TypeConverter from ConvertMemrefStore
when adding the disableAtomicRMW flag. Restore it.
---
 mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp b/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
index d24224355ed51..8686f22c9e3c2 100644
--- a/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
+++ b/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
@@ -415,8 +415,9 @@ struct ConvertMemRefReinterpretCast final
 struct ConvertMemrefStore final : OpConversionPattern<memref::StoreOp> {
   using OpConversionPattern::OpConversionPattern;
 
-  ConvertMemrefStore(MLIRContext *context, bool disableAtomicRMW)
-      : OpConversionPattern<memref::StoreOp>(context),
+  ConvertMemrefStore(const TypeConverter &typeConverter, MLIRContext *context,
+                     bool disableAtomicRMW)
+      : OpConversionPattern<memref::StoreOp>(typeConverter, context),
         disableAtomicRMW(disableAtomicRMW) {}
 
   LogicalResult
@@ -639,7 +640,8 @@ void memref::populateMemRefNarrowTypeEmulationPatterns(
                ConvertMemRefAssumeAlignment, ConvertMemRefMemorySpaceCast,
                ConvertMemRefSubview, ConvertMemRefReinterpretCast>(
       typeConverter, patterns.getContext());
-  patterns.insert<ConvertMemrefStore>(patterns.getContext(), disableAtomicRMW);
+  patterns.insert<ConvertMemrefStore>(typeConverter, patterns.getContext(),
+                                      disableAtomicRMW);
   memref::populateResolveExtractStridedMetadataPatterns(patterns);
 }
 



More information about the Mlir-commits mailing list