[Mlir-commits] [mlir] [mlir][memref] Pass TypeConverter to ConvertMemrefStore (PR #194356)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-memref

Author: Daniel Hernandez-Juarez (dhernandez0)

<details>
<summary>Changes</summary>

Commit 20b925a28a29 dropped the TypeConverter from ConvertMemrefStore when adding the disableAtomicRMW flag. Restore it.

---
Full diff: https://github.com/llvm/llvm-project/pull/194356.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp (+5-3) 


``````````diff
diff --git a/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp b/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
index d24224355ed51..8686f22c9e3c2 100644
--- a/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
+++ b/mlir/lib/Dialect/MemRef/Transforms/EmulateNarrowType.cpp
@@ -415,8 +415,9 @@ struct ConvertMemRefReinterpretCast final
 struct ConvertMemrefStore final : OpConversionPattern<memref::StoreOp> {
   using OpConversionPattern::OpConversionPattern;
 
-  ConvertMemrefStore(MLIRContext *context, bool disableAtomicRMW)
-      : OpConversionPattern<memref::StoreOp>(context),
+  ConvertMemrefStore(const TypeConverter &typeConverter, MLIRContext *context,
+                     bool disableAtomicRMW)
+      : OpConversionPattern<memref::StoreOp>(typeConverter, context),
         disableAtomicRMW(disableAtomicRMW) {}
 
   LogicalResult
@@ -639,7 +640,8 @@ void memref::populateMemRefNarrowTypeEmulationPatterns(
                ConvertMemRefAssumeAlignment, ConvertMemRefMemorySpaceCast,
                ConvertMemRefSubview, ConvertMemRefReinterpretCast>(
       typeConverter, patterns.getContext());
-  patterns.insert<ConvertMemrefStore>(patterns.getContext(), disableAtomicRMW);
+  patterns.insert<ConvertMemrefStore>(typeConverter, patterns.getContext(),
+                                      disableAtomicRMW);
   memref::populateResolveExtractStridedMetadataPatterns(patterns);
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/194356