[Mlir-commits] [mlir] [NFC][MLIR][NVVM] Add unit and Python bindings tests for MBarrierTestWaitOp/MBarrierTryWaitOp (PR #193600)

[Maksim Levental]

================

----------------
makslevental wrote:

> I don't want to inline it to the .cpp because the .cpp could become unreadable if/when more unit tests are added

By that logic the inc file themselves are already unreadable? If you're thinking the test file will grow and make it unreadable by nature of its length, I personally don't think that's a truism (long files with short local functions are generally pretty readable) and it's not a style/priority generally in LLVM/MLIR. Also .inc is the extension we use for generated files. Also without .h.inc or .cpp.inc most editors won't highlight the file correctly. 

But I actually took a closer look at what's in the file (ie what you're testing) and I see you're literally just testing builders. You don't need to test this because this is all tablegen-driven generated code and we already thoroughly test the tablegen generation. Same goes for the Python. 

So although I appreciate you trying to contribute tests, this isn't a useful set of tests/PR overall.

https://github.com/llvm/llvm-project/pull/193600