[Mlir-commits] [mlir] [MLIR][Affine] Fix isTilingValid missing anti-dependence when lb == ub < 0 (PR #192858)

[Oleksandr Alex Zinenko]

================
@@ -557,7 +557,7 @@ bool mlir::affine::isTilingValid(ArrayRef<AffineForOp> loops) {
                               OpPrintingFlags().skipRegions());
         for (const DependenceComponent &depComp : depComps) {
           if (depComp.lb.has_value() && depComp.ub.has_value() &&
-              *depComp.lb < *depComp.ub && *depComp.ub < 0) {
+              *depComp.ub < 0) {
----------------
ftynse wrote:

Why this is not changed to a `<=` check? I think the intent of the check was to say that the range of bounds is non-empty, i.e., the lower bound is less than the upper bound. But the upper bound is inclusive.

https://github.com/llvm/llvm-project/pull/192858