[Mlir-commits] [mlir] [mlir][SPIR-V][VectorToSPIRV] Add conversion patterns for vector.gather/scatter to SPIR-V (PR #193422)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- mlir/test/lib/Conversion/VectorToSPIRV/TestVectorGatherScatterToSPIRV.cpp mlir/include/mlir/Conversion/VectorToSPIRV/VectorToSPIRV.h mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp mlir/tools/mlir-opt/mlir-opt.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp b/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
index 3d2d6a27b..48dbb4363 100644
--- a/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
+++ b/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp
@@ -881,9 +881,9 @@ struct VectorGatherOpConverter final
     const auto &typeConverter = *getTypeConverter<SPIRVTypeConverter>();
     if (!typeConverter.getTargetEnv().allows(
             spirv::Extension::SPV_INTEL_masked_gather_scatter))
-      return rewriter.notifyMatchFailure(
-          gatherOp, "target environment does not enable "
-                    "SPV_INTEL_masked_gather_scatter");
+      return rewriter.notifyMatchFailure(gatherOp,
+                                         "target environment does not enable "
+                                         "SPV_INTEL_masked_gather_scatter");
     auto loc = gatherOp.getLoc();
 
     // Compute base element pointer from memref + offsets.
@@ -966,9 +966,9 @@ struct VectorScatterOpConverter final
     const auto &typeConverter = *getTypeConverter<SPIRVTypeConverter>();
     if (!typeConverter.getTargetEnv().allows(
             spirv::Extension::SPV_INTEL_masked_gather_scatter))
-      return rewriter.notifyMatchFailure(
-          scatterOp, "target environment does not enable "
-                     "SPV_INTEL_masked_gather_scatter");
+      return rewriter.notifyMatchFailure(scatterOp,
+                                         "target environment does not enable "
+                                         "SPV_INTEL_masked_gather_scatter");
     auto loc = scatterOp.getLoc();
 
     // Compute base element pointer from memref + offsets.

``````````

</details>


https://github.com/llvm/llvm-project/pull/193422