https://github.com/ilovepi commented: I think (modulo the existing comments by @banach-space) this patch is basically LGTM. I'll give it another pass once you've address those, but this looks great so far. https://github.com/llvm/llvm-project/pull/188459