[Mlir-commits] [mlir] [mlir][spirv] Add SPV_EXT_FP8 type support to SPIR-V TOSA ops (PR #193199)

[Igor Wodiany]

================
@@ -22,16 +22,20 @@ def SPIRV_I8OrI16OrI32OrI64 : AnyIntOfWidths<[8, 16, 32, 64]>;
 def SPIRV_I16OrI32 : AnyIntOfWidths<[16, 32]>;
 def SPIRV_I32OrI64 : AnyIntOfWidths<[32, 64]>;
 def SPIRV_F16OrF32OrBF16 : AnyTypeOf<[SPIRV_Float16, SPIRV_Float32, SPIRV_BFloat16KHR]>;
-def SPIRV_I8OrF16OrF32OrBF16 : AnyTypeOf<[SPIRV_Int8, SPIRV_F16OrF32OrBF16]>;
+def SPIRV_F16OrF32OrBF16OrF8E4M3FNOrF8E5M2 : AnyTypeOf<[SPIRV_Float16, SPIRV_Float32, SPIRV_BFloat16KHR, SPIRV_Float8E4M3EXT, SPIRV_Float8E5M2EXT]>;
----------------
IgWod wrote:

```suggestion
def SPIRV_F16OrF32OrBF16OrF8 : AnyTypeOf<[SPIRV_Float16, SPIRV_Float32, SPIRV_BFloat16KHR, SPIRV_Float8E4M3EXT, SPIRV_Float8E5M2EXT]>;
```

Same suggestion for the `def`s below. I think saying `F8` in this context is sufficient and the names are already long.

https://github.com/llvm/llvm-project/pull/193199