[Mlir-commits] [mlir] [OpenMP][MLIR] Add num_threads mlir->llvm lowering (PR #179420)

[llvmlistbot at llvm.org]

skc7 wrote:

> Thank you Chaitanya for this work.
> 
> The main concern I have with the current state of this patch is that the only functional difference it would cause is that, rather than telling users that a multi-dim `num_threads` clause on `parallel` inside of a `target` region isn't supported, we would treat it as if only the first dimension was specified and silently ignore the rest.
> 
> It seems like we'd be better off leaving things as they are until we can properly support these extra dims, what do you think?

@skatrak 

Currently all OmpIRBuilder and other clang changes are done by @kevinsala and I would only merge these multi-dim clauses mlir changes once proper testing is completed on top of clang changes.


https://github.com/llvm/llvm-project/pull/179420