[Mlir-commits] [mlir] [MLIR][NVVM] Adds an explicit aligned boolean attribute to nvvm.barrier (PR #192203)

[llvmlistbot at llvm.org]

xys-syx wrote:

> > Thanks @durga4github. The reduction aligned lowering in this PR is the direct mirror of the sync one (~15 lines, same helper pattern, same attribute and verifier). Splitting them would either leave a silent miscompilation (attribute added but not consumed for reductions) or require a temporary verifier rejection to be deleted in the follow-up, which doesn't read as cleaner than keeping them together. The other reduction-adjacent work you might be worried about fixing `BarrierOp`'s result type for `and`/`or` and the reduction-variant import is already planned as a separate follow-up PR. Could you please share your concern?
> 
> Yes, I agree it adds a bit of temporary checks in verifiers for `red` but it would make the scope of this PR short/clean, make the review easier etc. :-) But I would leave it up to you..

Thanks @durga4github, split done. You can see the change in the latest push.

https://github.com/llvm/llvm-project/pull/192203