[Mlir-commits] [mlir] [mlir] Propagate `checkCommutativeEquivalent` into `isRegionEquivalentTo` (PR #192670)

[Mehdi Amini]

================
@@ -893,9 +893,9 @@ OperationEquivalence::isRegionEquivalentTo(Region *lhs, Region *rhs,
 
   // 4. Compare regions.
   for (auto regionPair : llvm::zip(lhs->getRegions(), rhs->getRegions()))
-    if (!isRegionEquivalentTo(&std::get<0>(regionPair),
-                              &std::get<1>(regionPair), checkEquivalent,
-                              markEquivalent, flags))
+    if (!isRegionEquivalentTo(
+            &std::get<0>(regionPair), &std::get<1>(regionPair), checkEquivalent,
+            markEquivalent, flags, checkCommutativeEquivalent))
----------------
joker-eph wrote:

Thanks, but we'll need a test for this.

If this is really coupled to the other change, it can't be submitted separately.

(But I'd also want to understand with more details why it can't have effect independently right now)

https://github.com/llvm/llvm-project/pull/192670