[Mlir-commits] [mlir] [MLIR][NVVM] Adds an explicit aligned boolean attribute to nvvm.barrier (PR #192203)

[Durgadoss R]

================
@@ -2916,9 +2917,8 @@ LogicalResult NVVM::SetMaxRegisterOp::verify() {
 }
 
 LogicalResult NVVM::BarrierOp::verify() {
-  if (getNumberOfThreads() && !getBarrierId())
-    return emitOpError(
-        "barrier id is missing, it should be set between 0 to 15");
+  if (getReductionOp() && getNumberOfThreads())
+    return emitOpError("reduction cannot be combined with number_of_threads");
----------------
durga4github wrote:

I think this was simply missed while adding the `red` support to this Op (or, probably the `count` variants of the intrinsics were missing then..).

The NVPTX BE tests are here: llvm/test/CodeGen/NVPTX/barrier.ll with support for both `all` and `count` variants of the `red` variants. It would be good to support them instead.

https://github.com/llvm/llvm-project/pull/192203