[Mlir-commits] [mlir] [mlir][Transforms] Refactor CSE side-effect cache access in read-conflict scan (PR #192178)

[llvmlistbot at llvm.org]

https://github.com/zackc6 updated https://github.com/llvm/llvm-project/pull/192178

>From 55f02e8bf71139d0cf21d7410b5d95ff80ff771b Mon Sep 17 00:00:00 2001
From: zack <zackchen666 at gmail.com>
Date: Wed, 15 Apr 2026 12:09:53 +0800
Subject: [PATCH] [mlir][Transforms] Fix CSE memEffectsCache handling for
 existing entries

---
 mlir/lib/Transforms/CSE.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/lib/Transforms/CSE.cpp b/mlir/lib/Transforms/CSE.cpp
index 4d25e5e7c92b6..d2e67e3eba1ca 100644
--- a/mlir/lib/Transforms/CSE.cpp
+++ b/mlir/lib/Transforms/CSE.cpp
@@ -196,7 +196,7 @@ bool CSEDriver::hasOtherSideEffectingOpInBetween(Operation *fromOp,
   Operation *nextOp = fromOp->getNextNode();
   auto result =
       memEffectsCache.try_emplace(fromOp, std::make_pair(fromOp, nullptr));
-  if (result.second) {
+  if (!result.second) {
     auto memEffectsCachePair = result.first->second;
     if (memEffectsCachePair.second == nullptr) {
       // No MemoryEffects::Write has been detected until the cached operation.