[Mlir-commits] [mlir] [mlir][vector] Fold vector extract from insert when trailing unit dims (PR #192109)

[Kunwar Grover]

Groverkss wrote:

> LGTM, but please wait for other opinions before merging: I question that vector.insert is implicitly broadcasting...
> 
> This reminds me of: https://discourse.llvm.org/t/rfc-remove-implicit-bitcast-behavior-of-vector-extract/90178 and I wonder if insert shouldn't just follow extract here.
> 
> I'm interested for @banach-space and @dcaballe opinion

I don't think vector.insert is implicitly broadcasting here.

https://github.com/llvm/llvm-project/pull/192109