[Mlir-commits] [mlir] [mlir] Fix definition of type traits struct member for some ops (PR #192047)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-core

Author: Yoni Katzuv (YoniKF)

<details>
<summary>Changes</summary>

This commit fixes all appearences of `numLowBitsAvailable` to the correct `NumLowBitsAvailable`. Prior to this change, instantiation of templates like `llvm::PointerIntPair<mlir::ModuleOp, 3>` would not compile.

---
Full diff: https://github.com/llvm/llvm-project/pull/192047.diff


4 Files Affected:

- (modified) mlir/include/mlir/Dialect/Async/IR/Async.h (+1-1) 
- (modified) mlir/include/mlir/Dialect/Func/IR/FuncOps.h (+1-1) 
- (modified) mlir/include/mlir/Dialect/SPIRV/IR/SPIRVOps.h (+1-1) 
- (modified) mlir/include/mlir/IR/BuiltinOps.h (+1-1) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Async/IR/Async.h b/mlir/include/mlir/Dialect/Async/IR/Async.h
index 015d97357144b..f16e87e71373a 100644
--- a/mlir/include/mlir/Dialect/Async/IR/Async.h
+++ b/mlir/include/mlir/Dialect/Async/IR/Async.h
@@ -67,7 +67,7 @@ struct PointerLikeTypeTraits<mlir::async::FuncOp> {
   static inline mlir::async::FuncOp getFromVoidPointer(void *p) {
     return mlir::async::FuncOp::getFromOpaquePointer(p);
   }
-  static constexpr int numLowBitsAvailable = 3;
+  static constexpr int NumLowBitsAvailable = 3;
 };
 } // namespace llvm
 
diff --git a/mlir/include/mlir/Dialect/Func/IR/FuncOps.h b/mlir/include/mlir/Dialect/Func/IR/FuncOps.h
index 5e10a9f50b774..e12c31855e918 100644
--- a/mlir/include/mlir/Dialect/Func/IR/FuncOps.h
+++ b/mlir/include/mlir/Dialect/Func/IR/FuncOps.h
@@ -41,7 +41,7 @@ struct PointerLikeTypeTraits<mlir::func::FuncOp> {
   static inline mlir::func::FuncOp getFromVoidPointer(void *p) {
     return mlir::func::FuncOp::getFromOpaquePointer(p);
   }
-  static constexpr int numLowBitsAvailable = 3;
+  static constexpr int NumLowBitsAvailable = 3;
 };
 } // namespace llvm
 
diff --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVOps.h b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVOps.h
index 4d43c7d7066ed..34e2ff388bcea 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVOps.h
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVOps.h
@@ -57,7 +57,7 @@ struct PointerLikeTypeTraits<mlir::spirv::FuncOp> {
   static inline mlir::spirv::FuncOp getFromVoidPointer(void *p) {
     return mlir::spirv::FuncOp::getFromOpaquePointer(p);
   }
-  static constexpr int numLowBitsAvailable = 3;
+  static constexpr int NumLowBitsAvailable = 3;
 };
 
 } // namespace llvm
diff --git a/mlir/include/mlir/IR/BuiltinOps.h b/mlir/include/mlir/IR/BuiltinOps.h
index 1c31ef32324f5..bfecf63fe658d 100644
--- a/mlir/include/mlir/IR/BuiltinOps.h
+++ b/mlir/include/mlir/IR/BuiltinOps.h
@@ -40,7 +40,7 @@ struct PointerLikeTypeTraits<mlir::ModuleOp> {
   static inline mlir::ModuleOp getFromVoidPointer(void *p) {
     return mlir::ModuleOp::getFromOpaquePointer(p);
   }
-  static constexpr int numLowBitsAvailable = 3;
+  static constexpr int NumLowBitsAvailable = 3;
 };
 } // namespace llvm
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/192047