[Mlir-commits] [mlir] [mlir][memref] Make memref.cast areCastCompatible return true when meet same types (PR #192029)

[lonely eagle]

linuxlonelyeagle wrote:

> Please update the op documentation along with the change, it currently spells out that only ranked memrefs are supported.
> 
> I don't have a strong reason not to allow this, but this needs a better, more specific justification than "impacts downstream projects", ideally that relates to upstream mlir.

I have reviewed the MLIR documentation regarding memref.cast https://mlir.llvm.org/docs/Dialects/MemRef/#memrefcast-memrefcastop, it say "b. Either or both memref types are unranked with the same element type, and address space.", `Either or both` "Actually, I'm wondering if it was originally intended to be supported this way, but the implementation just diverged.

https://github.com/llvm/llvm-project/pull/192029