[Mlir-commits] [mlir] [mlir] Use a container with deterministic iteration order for unrealized materializations (PR #191323)

[Matthias Springer]

matthias-springer wrote:

Can you describe on a high level why a non-deterministic iteration order leads to non-deterministic results? Each `unrealized_conversion_cast` op is replaced with an op that is produced by the type converter (source/target materialization). Why does it matter in which order those replacement ops are generated?

I don't see a problem with this PR, but switching from `DenseMap` to `MapVector` may degrade compilation time slightly, and I'd like to understand why the order matters here.


https://github.com/llvm/llvm-project/pull/191323