[Mlir-commits] [flang] [mlir] [mlir][func] Fix crashes in FuncToLLVM discardable attributes propagation logic (PR #188232)

[Mehdi Amini]

joker-eph wrote:

Actually the mlir-opt part of the test which involves this pass is independent of the JIT environment, so I could run it locally, here is the diff:
```
$ diff /tmp/after  /tmp/before 
5c5
<   llvm.func @matmul_transpose_a(%arg0: !llvm.ptr, %arg1: !llvm.ptr, %arg2: i64, %arg3: i64, %arg4: i64, %arg5: i64, %arg6: i64, %arg7: !llvm.ptr, %arg8: !llvm.ptr, %arg9: i64, %arg10: i64, %arg11: i64, %arg12: i64, %arg13: i64, %arg14: !llvm.ptr, %arg15: !llvm.ptr, %arg16: i64, %arg17: i64, %arg18: i64, %arg19: i64, %arg20: i64) {
---
>   llvm.func @matmul_transpose_a(%arg0: !llvm.ptr, %arg1: !llvm.ptr, %arg2: i64, %arg3: i64, %arg4: i64, %arg5: i64, %arg6: i64, %arg7: !llvm.ptr, %arg8: !llvm.ptr, %arg9: i64, %arg10: i64, %arg11: i64, %arg12: i64, %arg13: i64, %arg14: !llvm.ptr, %arg15: !llvm.ptr, %arg16: i64, %arg17: i64, %arg18: i64, %arg19: i64, %arg20: i64) attributes {arm_locally_streaming, arm_new_za} {

```

So we have two attributes that gets dropped unexpectedly here, because they aren't prefixed. 

The fix is to add the `llvm.` prefix in `mlir/lib/Dialect/ArmSME/Transforms/EnableArmStreaming.cpp`

https://github.com/llvm/llvm-project/pull/188232