[Mlir-commits] [mlir] [mlir][EmitC] Convert math::RoundEvenOp, SqrtOp and RsqrtOp (PR #190158)

[Gil Rapaport]

aniragil wrote:

Thanks for the patch!
LGTM, just wondering about the combined testing: is it common practice to test "composed lowering"? doesn't it create redundant dependency on what the math-expanding pass does?
The `mlir-runner` test `test-expand-math-approx.mlir` seems to do something similar for `llvm`, is this its `emitc` equivalent? There's also the `tosa` directory in emitc doing similar end-to-end lowering for `tosa` (not sure how I feel about that either).


https://github.com/llvm/llvm-project/pull/190158