https://github.com/IgWod commented: Looks good! One more nit and we should also add a test to: https://github.com/llvm/llvm-project/blob/main/mlir/test/Dialect/SPIRV/IR/types.mlir https://github.com/llvm/llvm-project/pull/189891