[Mlir-commits] [mlir] [mlir][linalg] Improve UnPackOp tiling for perfect-tiling cases. (PR #189470)

[Jerry Shih]

JerryShih wrote:

> > I don't know whether the zero value is valid or not in getTiledImplementation()'s `sizes` argument. If the zero value means `no tiling`, then we could handle all cases without using `isEqualConstantIntOrValue()`
> 
> Yes, zero value means `no tiling`for that dimension.

Thx. but the caller need to pass the zero value at: 
https://github.com/llvm/llvm-project/blob/495e1a42579c8f540303ab72e6449a448b89e537/mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp#L829
https://github.com/llvm/llvm-project/blob/495e1a42579c8f540303ab72e6449a448b89e537/mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp#L285-L291

I am not sure the all getTiledImplementation() could handle the zero value or not.

https://github.com/llvm/llvm-project/pull/189470