[Mlir-commits] [mlir] [mlir][tensor] Forward concat insert_slice destination into DPS provider (PR #183490)

[Han-Chung Wang]

================
@@ -246,6 +246,7 @@ struct InsertSliceOfInsertSliceFolder : public OpRewritePattern<OpTy> {
 
 void tensor::populateFoldTensorSubsetOpPatterns(RewritePatternSet &patterns) {
   populateFoldTensorSubsetIntoVectorTransferPatterns(patterns);
+  populateForwardConcatInsertSliceDestPatterns(patterns);
----------------
hanhanW wrote:

If you're going to move inline the implementation to `ConcatConverter::matchAndRewrite`, the pattern is no longer useful? In this context, why not revert the commit? I'm okay with the follow-up commit, I'm just confused.

https://github.com/llvm/llvm-project/pull/183490