[Mlir-commits] [mlir] 461a1c5 - [mlir][ods] resolve the wrong indent issue (#189277)

[llvmlistbot at llvm.org]

Author: AidinT
Date: 2026-04-01T15:20:54+02:00
New Revision: 461a1c51bf0998edc1fd3b9b7197437136c2fb18

URL: https://github.com/llvm/llvm-project/commit/461a1c51bf0998edc1fd3b9b7197437136c2fb18
DIFF: https://github.com/llvm/llvm-project/commit/461a1c51bf0998edc1fd3b9b7197437136c2fb18.diff

LOG: [mlir][ods] resolve the wrong indent issue (#189277)

The `emitSummaryAndDescComments` is used to generate summary and
description for tablegen generated classes and structs such as Dialects
and Interfaces. The generated summary and description is indented
incorrectly in the output generated file. For example
`NVGPUDialect.h.inc ` looks like the following:

```cpp
namespace mlir::nvgpu {

/// The `NVGPU` dialect provides a bridge between higher-level target-agnostic
///     dialects (GPU and Vector) and the lower-level target-specific dialect
///     (LLVM IR based NVVM dialect) for NVIDIA GPUs. This allow representing PTX
///     specific operations while using MLIR high level dialects such as Memref
///     and Vector for memory and target-specific register operands, respectively.
class NVGPUDialect : public ::mlir::Dialect {
    ...
  };

} // namespace mlir::nvgpu
```

This is because the `emitSummaryAndDescComments` trims the summary and
description from both sides, rendering the re-indentation useless. This
PR resolves this bug.

Added: 
    

Modified: 
    mlir/tools/mlir-tblgen/CppGenUtilities.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/tools/mlir-tblgen/CppGenUtilities.cpp b/mlir/tools/mlir-tblgen/CppGenUtilities.cpp
index 7cead353396dd..6c05d5336224d 100644
--- a/mlir/tools/mlir-tblgen/CppGenUtilities.cpp
+++ b/mlir/tools/mlir-tblgen/CppGenUtilities.cpp
@@ -18,8 +18,8 @@ void mlir::tblgen::emitSummaryAndDescComments(llvm::raw_ostream &os,
                                               llvm::StringRef summary,
                                               llvm::StringRef description,
                                               bool terminateComment) {
-  StringRef trimmedSummary = summary.trim();
-  StringRef trimmedDesc = description.trim();
+  StringRef trimmedSummary = summary.rtrim();
+  StringRef trimmedDesc = description.rtrim();
   raw_indented_ostream ros(os);
 
   bool empty = true;