[Mlir-commits] [mlir] [MLIR][Analysis] Fix incorrect RegionBranchOpInterface API usage in SliceWalk (PR #188758)

[Mehdi Amini]

joker-eph wrote:

> > OK, thanks. These looks a bit noisy and can be disruptive for other reviewers (or the author), I would suggest keeping the comments to things that are actionable if possible. Thanks for the review!
> 
> Cool, noted, I'm keeping the main logic changes annotation, I feel like it's a bit hard to keep up with the logic

This is indeed the kind of annotation I'm often writing down myself locally when I analyse a PR for review, I just don't think their place is on the PR during the review process. At least I've never seen this elsewhere so far.

https://github.com/llvm/llvm-project/pull/188758