[Mlir-commits] [mlir] [MLIR][LivenessAnalysis] Treat a public function as an external (PR #160648)

[xin liu]

navyxliu wrote:

> I'm wondering now if this is the right fix though. Making arguments as dead could still allow simplification at call-sites (for example: replace with a constant or an "undef" value), while not touching the signature?

yes. that's what I wrote in PR #160242. 
> With a non-live argument from callee, we could replace it with a dummy placeholder like arith.constant 0 : i32. It would be impossible if we mark all arguments of a public function live.

The problem is whether it is always possible to find cheaper replacement?  What about an aggregated type? 

if we fail, we need to propagate live arguments in RemoveDeadValues just like PR #160242


https://github.com/llvm/llvm-project/pull/160648