[Mlir-commits] [mlir] Add options to generate-runtime-verification to enable faster pass running (PR #160331)

[Mehdi Amini]

================
@@ -36,10 +44,46 @@ void GenerateRuntimeVerificationPass::runOnOperation() {
     ops.push_back(verifiableOp);
   });
 
+  // Create error message generator based on verboseLevel
----------------
joker-eph wrote:

It's an excellent point, but isn't it an issue of the current pass that we're reconstructing the SSA numbering between each application of the instrumentation?

I would think the user would likely want to match the message to the IR as printed before the pass instead of some state that only exists in the middle of the application of the pass?

That said we can definitely land this PR as-is, to not affect the behavior too much, and then try to land an update where we construct an AsmState and cache it for the duration of the pass?

https://github.com/llvm/llvm-project/pull/160331