[Mlir-commits] [mlir] [mlir] [irdl] Add support for regions in irdl-to-cpp (PR #158540)

[Théo Degioanni]

https://github.com/Moxinilian commented:

Thank you very much for this!

For the interface for verification: my intuition is that the non-impl version could be a public interface? But to be quite frank I am not familiar enough with ODS internals to know for sure. This could be a good question to ask on MLIR Discord!

For testing: could you also add something that uses the conditional op and its regions in `TestIRDLToCppDialect.cpp` and test that separately in `test_conversion.testd.mlir`? Maybe a lowering to scf.if next to the other conversion rewrites, why not?

https://github.com/llvm/llvm-project/pull/158540