[Mlir-commits] [mlir] [mlir][arith] Add canonicalize pattern for max/min with constants (PR #161057)

Mehdi Amini llvmlistbot at llvm.org
Mon Sep 29 03:44:42 PDT 2025


joker-eph wrote:

> I just followed the same approach as AddIOp

These should likely be moved to a folder then.

>  Maybe implementing this as a TableGen pattern could simplify the code?

Can you use DRR pattern to implement folders?

More importantly here: 

> Also, isn't this something that we should generically do in the folder for the IsCommutative trait?

https://github.com/llvm/llvm-project/pull/161057


More information about the Mlir-commits mailing list