[Mlir-commits] [mlir] WIP: Add support for regions in irdl-to-cpp (PR #158540)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Fri Sep 26 21:50:49 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp b/mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp
index 92a9c59ec..abe7b1a63 100644
--- a/mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp
+++ b/mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp
@@ -141,13 +141,13 @@ static void fillDict(irdl::detail::dictionary &dict, const OpStrings &strings) {
dict["OP_RESULT_INITIALIZER_LIST"] =
resultCount ? joinNameList(strings.opResultNames) : "{\"\"}";
dict["OP_REGION_COUNT"] = std::to_string(regionCount);
- dict["OP_ADD_REGIONS"] =
- regionCount ? std::string(llvm::formatv(
- R"(for (unsigned i = 0; i != {0}; ++i)
+ dict["OP_ADD_REGIONS"] = regionCount
+ ? std::string(llvm::formatv(
+ R"(for (unsigned i = 0; i != {0}; ++i)
(void)odsState.addRegion();
)",
- regionCount))
- : "";
+ regionCount))
+ : "";
}
/// Fills a dictionary with values from DialectStrings
``````````
</details>
https://github.com/llvm/llvm-project/pull/158540
More information about the Mlir-commits
mailing list