[Mlir-commits] [mlir] [MLIR][LivenessAnalysis] Treat a public function as an external (PR #160648)

[xin liu]

================
@@ -503,12 +504,18 @@ AbstractSparseBackwardDataFlowAnalysis::visitOperation(Operation *op) {
       // If the call invokes an external function (or a function treated as
       // external due to config), defer to the corresponding extension hook.
       // By default, it just does `visitCallOperand` for all operands.
+      //
+      // If callable is a public function, treat it as an external function.
+      // Transforms like RemoveDeadValues cannot change the arguments or returns
+      // of it.
----------------
navyxliu wrote:

I misunderstood. Your standpoint is the whole program. My standpoint is RemoveDeadValues. 
your comment makes sense to me.update. 



https://github.com/llvm/llvm-project/pull/160648