[Mlir-commits] [mlir] [mlir][vector] Rename ConvertVectorToLLVM to NaiveConvertVectorToLLVM (PR #160055)

[Andrzej Warzyński]

banach-space wrote:

Thank you all for your feedback, some really good points have been raised!

> My suggestion was to materialize the actual conversion changes first and think about the name later as it's unclear the resulting pass is going to be naive or we want to call it something else.

Naming is hard 😅 … However, I would like to start signalling to folks ASAP that this pass is intended as trivial/unoptimised/POC. We may need to adjust again, but this step improves clarity today.

> I think it's important to set the expectations in the pass documentation 

Agreed. I’ve added a high-level description in the Vector dialect docs. Happy to iterate on this if more detail would be useful.

> The way I read the RFC, renaming also serves to make room for such pipelines to exist, rather than incorrectly assuming that ---since there is already one pipelin, the work is done.

Indeed!

>  When we discussed this, my understand was to rename it to "Naive" when we have all the pieces broken down and can actually say how you could build your own pipeline for your own usecase.

My intent is to signal early that this pass is limited and will become even more so as functionality is split out. I want to make this clear to our users as well as maintainers ;-)

-Andrzej

https://github.com/llvm/llvm-project/pull/160055