[Mlir-commits] [mlir] [mlir][tosa] Add the concept of a TOSA target environment (PR #153771)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- mlir/lib/Dialect/Tosa/IR/TargetEnv.cpp mlir/lib/Dialect/Tosa/Transforms/TosaAttachTarget.cpp mlir/include/mlir/Conversion/TosaToLinalg/TosaToLinalg.h mlir/include/mlir/Dialect/Tosa/IR/TargetEnv.h mlir/include/mlir/Dialect/Tosa/Transforms/Passes.h mlir/lib/Conversion/TosaToLinalg/TosaToLinalgPass.cpp mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp b/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
index 0938f9a0f..82f2f7eb1 100644
--- a/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
+++ b/mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
@@ -513,13 +513,13 @@ private:
 template <>
 LogicalResult TosaValidation::levelCheckRanks(tosa::ArgMaxOp tosaOp) {
   auto *op = tosaOp.getOperation();
-  if (failed(
-          levelCheckRank(op, tosaOp.getInput(), "operand", targetEnv.getLevel().MAX_RANK)))
+  if (failed(levelCheckRank(op, tosaOp.getInput(), "operand",
+                            targetEnv.getLevel().MAX_RANK)))
     return failure();
 
   // rank(output) = rank(input) - 1
   if (failed(levelCheckRank(op, tosaOp.getOutput(), "result",
-        targetEnv.getLevel().MAX_RANK - 1)))
+                            targetEnv.getLevel().MAX_RANK - 1)))
     return failure();
 
   return success();
@@ -542,7 +542,7 @@ LogicalResult TosaValidation::levelCheckRanks(tosa::VariableOp tosaOp) {
   auto *op = tosaOp.getOperation();
   auto variableType = getVariableType(tosaOp);
   if (failed(levelCheckRank(op, variableType, "variable type",
-    targetEnv.getLevel().MAX_RANK)))
+                            targetEnv.getLevel().MAX_RANK)))
     return failure();
 
   return success();
@@ -699,7 +699,8 @@ LogicalResult TosaValidation::levelCheckSize(Operation *op,
     // defined in 1.7. Levels.
     // For each tensor, the number of tensor elements multiplied by the
     // element size in bytes must be representable as a tensor_size_t.
-    const int64_t max_size = (INT64_C(1) << targetEnv.getLevel().MAX_LOG2_SIZE) - 1;
+    const int64_t max_size =
+        (INT64_C(1) << targetEnv.getLevel().MAX_LOG2_SIZE) - 1;
     if (size > max_size)
       return op->emitOpError()
              << "failed level check: " << operandOrResult

``````````

</details>


https://github.com/llvm/llvm-project/pull/153771