[Mlir-commits] [mlir] [mlir][vector] Rename ConvertVectorToLLVM to NaiveConvertVectorToLLVM (PR #160055)

[Diego Caballero]

dcaballe wrote:

My point was more about doing a large renaming now and having to revisit it again after materializing the actual changes that we agreed upon than about the actual naming itself. For context, we agreed that we'd move target specific or opinionated lowerings like vector contractions, transposes, vector unrolling, vector linearization... to separate passes and keep the vector conversion to LLVM simpler. However, this PR is renaming the conversion pass but the pass is doing exactly the same conversions, including the ones that we plan to move out (definitely nothing naive yet). My suggestion was to materialize the actual conversion changes first and think about the name later as it's unclear the resulting pass is going to be naive or we want to call it something else.

I'm not blocking anything here but that's my view.



https://github.com/llvm/llvm-project/pull/160055