[Mlir-commits] [mlir] [mlir] Implement a memory-space cast bubbling-down transform (PR #159454)

[Fabian Mora]

================
@@ -1284,6 +1288,7 @@ def LoadOp : MemRef_Op<"load",
 def MemRef_MemorySpaceCastOp : MemRef_Op<"memory_space_cast", [
       DeclareOpInterfaceMethods<CastOpInterface>,
       DeclareOpInterfaceMethods<OpAsmOpInterface, ["getAsmResultNames"]>,
+      MemorySpaceCastOpInterface,
----------------
fabianmcg wrote:

Are you referring to the ODS description? I added doc lines in the `extraClassDeclaration` saying:
```C++
    /// Returns whether the `source` value can be promoted by the
    /// `MemorySpaceCastConsumerOpInterface::bubbleDownCasts` method. The only
    /// casts the op recognizes as promotable are to the generic memory-space.
```

I can add a note on the description, however, I'm not sure it belongs there because that's impl details and not part of the op. But I can see your argument, so just triple checking on what you mean before adding the note.

https://github.com/llvm/llvm-project/pull/159454