[Mlir-commits] [mlir] [Linalg] Fix linalg.pack canonicalization priority issue (PR #160340)

[Nirvedh Meshram]

================
@@ -5581,6 +5581,14 @@ static bool inferStaticShape(PackOp packOp, SmallVectorImpl<int64_t> &srcShape,
 }
 
 LogicalResult PackOp::canonicalize(PackOp packOp, PatternRewriter &rewriter) {
+  // Fold optional PaddingValue operand away if padding is not needed.
+  if (packOp.getPaddingValue() && paddingIsNotNeeded(packOp)) {
+    rewriter.startOpModification(packOp);
+    packOp.getPaddingValueMutable().clear();
+    rewriter.finalizeOpModification(packOp);
+    return success();
+  }
+
----------------
nirvedhmeshram wrote:

Yes that would be much better, done!

https://github.com/llvm/llvm-project/pull/160340