[Mlir-commits] [mlir] [MLIR][Python] Add bindings for PDL native rewrite function registering (PR #159926)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Sep 23 07:50:49 PDT 2025


================
@@ -53,7 +53,7 @@ public:
   /// value is not an instance of `T`.
   template <typename T,
             typename ResultT = std::conditional_t<
-                std::is_convertible<T, bool>::value, T, std::optional<T>>>
+                std::is_constructible_v<bool, T>, T, std::optional<T>>>
----------------
PragmaTwice wrote:

Yup. Due to this review suggestion https://github.com/llvm/llvm-project/pull/159926#discussion_r2371401480, now we use `dyn_cast` instead of `isa` and `cast` of PDLValue. And this change is to address issues in PDLValue::dyn_cast.

https://github.com/llvm/llvm-project/pull/159926


More information about the Mlir-commits mailing list