[Mlir-commits] [mlir] [MLIR][Python] Add bindings for PDL native rewrite function registering (PR #159926)

[Oleksandr Alex Zinenko]

================
@@ -323,6 +326,35 @@ MLIR_CAPI_EXPORTED void mlirPDLPatternModuleDestroy(MlirPDLPatternModule op);
 
 MLIR_CAPI_EXPORTED MlirRewritePatternSet
 mlirRewritePatternSetFromPDLPatternModule(MlirPDLPatternModule op);
+
+MLIR_CAPI_EXPORTED bool mlirPDLValueIsValue(MlirPDLValue value);
----------------
ftynse wrote:

The convention in C API so far is to do `typeIsASubType`, so `IsA` with an `A` to match the C++ API. Another nit is that `ValueIsAValue` sounds tautologically true, so I'd suggest `ValueIsAMlirValue` instead.

https://github.com/llvm/llvm-project/pull/159926