[Mlir-commits] [mlir] [mlir][spirv] Rework type extension queries (PR #160020)
Jakub Kuderski
llvmlistbot at llvm.org
Mon Sep 22 05:02:48 PDT 2025
kuhar wrote:
> Could we have a default implementation of `::getExtensions()` in `SPIRVType` class. This way we avoid repeating the same implementation in each inherited type, as they can just use the parent default. I think this also would help enforce that `::getExtensions()` is not abused as any custom implementation of `::getExtensions()` would have to be explicit.
Good idea, done. I wanted to preserve the existing API but didn't realize that all these `::getExtensions` functions in derived classes only shadow the main definition in `SPIRVType`.
https://github.com/llvm/llvm-project/pull/160020
More information about the Mlir-commits
mailing list